When AWS_ID is the placeholder value, act as though AWS not setup #13850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have "Optional" as the placeholder in the .env_sample When that's the "final" value in the .env file, assume we're actually going to use local storage instead.
pr-triage
bot
added
the
PR: draft
pr-triage
bot
added
PR: unreviewed
djuber
requested review from
a team,
joshpuetz and
juliannatetreault
and removed request for
a team
maestromac
approved these changes
May 24, 2021
pr-triage
bot
added
PR: partially-approved
rhymes
reviewed
May 25, 2021
There was a problem hiding this comment.
Can we fix the problem at the source? "Optional" is just an arbitrary value that has been there for no particular reason, it could be "ABCDEF".
I don't think we should hardcode it (there's nowhere else where we look for that specific value in the code)
What if we change the .env_sample to default to nothing? Same as we did in #13767
Revert the change to the carrierwave initializer (don't hardcode the placeholder value). Mimics choices we made for Cloudinary in #13767
pr-triage
bot
added
PR: unreviewed
|
OMG, I replied on the wrong PR. Deleted comments to hide my shame. |
rhymes
approved these changes
May 26, 2021
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
We have "Optional" as the placeholder in the .env_sample, if someone copied .env_sample to .env, they'd have AWS_ID present but not valid or meaningful.
When that's the "final" value in the .env file, assume we're actually going to use local storage instead.~Because there are related guards around production mode this should have limited to no prod impact (outside of self-hosting, where I assume this is a net-improvement in usability). Forem clould has its own configuration. ~
I'm surprised this hadn't been a bigger problem.Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Ensure
AWS_ID=in your .env, then load the appChange a user's profile image.
Ensure the new image is visible.
UI accessibility concerns?
None, this should be a develop/test only change.
Added tests?
[Forem core team only] How will this change be communicated?
Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.
[optional] Are there any post deployment tasks we need to perform?
None
[optional] What gif best describes this PR or how it makes you feel?