rust: Improve service handler wrappers #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloff
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Nice! Now I feel like the time I spent on that API was worth it.
Looks like you also made some improvements by making the Arc an implementation detail and making the errors generic. I tried the latter and ran into problems, I want to give it another look tomorrow.
This looks great.
| } | ||
|
|
||
| fn blocking_handler(_: Request) -> Result<Bytes, String> { | ||
| std::thread::sleep(Duration::from_secs(1)); |
There was a problem hiding this comment.
You could probably use shorter sleeps so the test runs faster
There was a problem hiding this comment.
Could, I suppose... but the client makes all of its /sleep calls in parallel, so it's only one second. Kind of nice to have that wait be user-visible, IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrow some good ideas for wrapping callbacks from @eloff's asset handler work in #229.
In particular, I love the idea of handling the
tokio::spawnandtokio::task::spawn_blockingon our side, because it handles the 99% case beautifully. Folks that want even finer control can always implementHandlerthemselves.Changes here:
handler_fn(which took(Request, Responder)as arguments).sync_handler_fnashandler_fn.blocking_handler_fnandasync_handler_fnfor blocking and async function handlers.'staticbounds.