Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose server port #255

Merged
merged 8 commits into from
Mar 1, 2025
Merged

Expose server port #255

merged 8 commits into from
Mar 1, 2025

Conversation

jtbandes
Copy link
Member

@jtbandes jtbandes commented Feb 28, 2025

Changelog

The server now exposes the port it's listening on, so you can pass a port of 0 and later determine the actual port used.

Docs

None

Description

Also tweaked a few memory orderings after discussing in slack – we can stick with the following defaults unless otherwise noted with a comment:

  • load: Acquire
  • store: Release
  • fetch_add/compare_exchange etc.: AcqRel

@jtbandes
Copy link
Member Author

What's the magic incantation to update the generated type stubs? Also – do we need a lint step to enforce that they're up to date?

@amacneil
Copy link
Contributor

Pretty sure they are manually authored

@bryfox
Copy link
Contributor

bryfox commented Feb 28, 2025

What's the magic incantation to update the generated type stubs? Also – do we need a lint step to enforce that they're up to date?

Yes, it's manual now, and relying on manual review (and unittest + mypy). I had a branch going to attempt to auto-generate them, but not there yet.

edit: FG-9900

@jtbandes jtbandes marked this pull request as ready for review February 28, 2025 22:47
@jtbandes jtbandes requested review from eloff, bryfox and gasmith February 28, 2025 22:47
@jtbandes jtbandes requested a review from gasmith February 28, 2025 23:39
Copy link
Contributor

@gasmith gasmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@jtbandes jtbandes merged commit 9448ccf into main Mar 1, 2025
36 checks passed
@jtbandes jtbandes deleted the jacob/port branch March 1, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants