-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose server port #255
Expose server port #255
Conversation
What's the magic incantation to update the generated type stubs? Also – do we need a lint step to enforce that they're up to date? |
Pretty sure they are manually authored |
Yes, it's manual now, and relying on manual review (and unittest + mypy). I had a branch going to attempt to auto-generate them, but not there yet. edit: FG-9900 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Changelog
The server now exposes the port it's listening on, so you can pass a port of 0 and later determine the actual port used.
Docs
None
Description
Also tweaked a few memory orderings after discussing in slack – we can stick with the following defaults unless otherwise noted with a comment: