Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix polytype bug #48

Merged
merged 2 commits into from
Jun 28, 2017
Merged

Fix polytype bug #48

merged 2 commits into from
Jun 28, 2017

Conversation

andyscott
Copy link
Member

@andyscott andyscott commented Jun 28, 2017 •
edited
Loading

Fixes an issue where poly types required an intermediate alias. Now the alias is no longer required.

peterneyens
peterneyens approved these changes Jun 28, 2017
View reviewed changes
Copy link
Member

@peterneyens peterneyens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit that I have no idea what is going on in projectPoly, but 🎉

@andyscott andyscott merged commit f736eef into master Jun 28, 2017
@andyscott andyscott deleted the polytype-bug branch June 28, 2017 20:47
@andyscott
Copy link
Member Author

It's a Type to Tree conversion where the input is an eta expanded type such as [zz]Either[String, zz] and the output is a compiler tree for a type lambda ({ type ξ[zz] = Either[String, zz] })#ξ. The parameter zz is ripped from the original type and used in the tree.

@andyscott
Copy link
Member Author

I could probably add some comments to explain that... * files todo *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterneyens peterneyens peterneyens approved these changes

@raulraja raulraja Awaiting requested review from raulraja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyscott @peterneyens