Split README / Fix Scalaz #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyscott
force-pushed
the
fix-scalaz
branch
2 times, most recently
from
9f051ef to
d3c4f40
Compare
andyscott
force-pushed
the
fix-scalaz
branch
from
d3c4f40 to
b57a7a6
Compare
andyscott
force-pushed
the
fix-scalaz
branch
from
b57a7a6 to
b334bfc
Compare
andyscott
force-pushed
the
fix-scalaz
branch
from
7f484d5 to
e00a92d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few remaining fixes in the tests to get the build green, but:
NaturalTransformation.Fixing Scalaz support
There was one big issue related to type inferencing for the parameters on
CopK.NaturalTransformation.of/summon. After a bit of debugging while at SBTB I've sorted out what seems to be the best solution.The short story is that the variances on Scalaz's NaturalTransformation cause the typer to simply assume
Nothing(or use an existential type) instead of computing a type tag. A potential solution was posted on SO several years ago, but this doesn't work for this use case.For the time being, Scalaz users will need to specify the type parameters when calling . If variances are removed from Scalaz, then this requirement should seamlessly disappear.
Thanks to @propensive for macro debugging assistance and @jdegoes for Scalaz roadmap discussion.