Add watchdog script written in Lua to the gluon-mesh-vpn-tunneldigger

[MPW1412]

package.

The logic is based on the former watchdog written in (B)ash.

The code was written by Robin Weiligmann admin@robwei.me and me.

[mweinelt]

Please use tabs for indentation everywhere.

[MPW1412]

Thanks for your feedback, @mweinelt. The latest commit does the requested changes.

[MPW1412]

Please use tabs for indentation everywhere.

Done in last commit. Had overseen it before.

[mweinelt]

The Gluon codebase uses lowercase function names with underlines separating words, not camel casing as you do.

readPidFile vs read_pid_file

[MPW1412]

The Gluon codebase uses lowercase function names with underlines separating words, not camel casing as you do.

readPidFile vs read_pid_file

✓

[blocktrron]

You mixed single and double quotes a lot in your file. This is very inconsistent in the rest of Gluon. However, while you are at it, you might want to bring a bit of consistency in your own file.

[MPW1412]

Thanks for your feedback, @blocktrron. I tried to address all points in the last commit.

[mweinelt]

Great progress, please test the latest version and report back.

[MPW1412]

I just tested it in x86-64. Works :)

[mweinelt]

Looks good to me, but since I cannot test this myself, will someone with a tunneldigger setup give this a testdrive and make sure this works as intended?

[MPW1412]

I already tested it...works. Do you want a second opinion?

[mweinelt]

Yup, that would be nice. I'm not very comfortable yet reviewing Lua.

[CodeFetch]

Looks good. Why did you use popen instead of execute for the logger? I'd use execute as it does not create a file handle in memory or at least directly closes it. Lua's garbage collection is not very clever and it might be possible that the file handle is only getting freed on garbage collection or program termination, but I'm not sure as you don't assign it to a variable at all... Just to be sure I'd use execute. This is still pedantic, as file handles don't really hurt. Your code is fine.

Edit: I'm curious... When does it happen that the PIDs don't match?
Edit2: And I just remember that file handle get closed when they are not being assigned to variables. So it makes no difference. Only for consistency with other code where execute is being used.

[MPW1412]

Hello @CodeFetch,

thanks for your feedback.

About the logging: Robin and I are not very familiar with Lua. When we first started this little project, we expected Lua to have some command or package to write to the syslog. But we couldn't find anything in other gluon packages.

So we just used the first best command we knew.

About edit(1): We don't know what the idea behind this is. We just ported the old (b)ash script to Lua as we were told (b)ash scripts wouldn't be accepted in Gluon anymore.

About edit(2): Okay, we'll stay with popen for now.

Best,
Matthias

[mweinelt]

Since we don't parse any return values we might use os.execute here as well, no?

[Adorfer]

works as expected on 841: After killing the tunneldigger process, the checkscript detected and made a new tunnel.

[mweinelt]

Squashed and merged with minor changes in 8e17635.

Thanks for your work!