site: disallow usage of outdoor mode in case outdoor_chanlist is missing #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
3. topic: config-mode
neocturne
reviewed
Jun 21, 2021
blocktrron
force-pushed
the
pr-outdoor-mode-optional
branch
2 times, most recently
from
ad585b7 to
963bcfd
Compare
neocturne
reviewed
Jul 12, 2021
| @@ -142,7 +142,7 @@ uci:foreach('wireless', 'wifi-device', function(config) | |||
| end) | |||
|
|
|||
|
|
|||
| if has_5ghz_radio() and not wireless.preserve_channels(uci) then | |||
| if has_5ghz_radio() and not wireless.preserve_channels(uci) and wireless.site_supports_outdoor_mode() then | |||
There was a problem hiding this comment.
I think we should also display the form when outdoor mode is already enabled.
neocturne
added
2. status: merge conflict
25 tasks
The documentation states the outdoor mode is only enabled in case outdoor_chanlist is defined in the sites wifi5 configurationsection: > If enabled, by setting ``wifi5.outdoor_chanlist``, a number of > devices that are commonly installed outdoors will have outdoor > mode automatically enabled during their initial setup This currently does not hold true, as Outdoor mode is always activated for these devices on first setup, even in case the site does not specify an outdoor chanlist. Furthermore, it also does not make sense to show the option neither in setup-modes basic nor advences configuration view in case the site is lacking an out door chanlist. This patch will disable outdoor mode on new installs in case the outdoor chanlist is missing. It will also not show the respective configuration options in this case. Signed-off-by: David Bauer <mail@david-bauer.net>
blocktrron
force-pushed
the
pr-outdoor-mode-optional
branch
from
963bcfd to
0edc998
Compare
rotanid
removed
the
2. status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently not yet tested on the repsective hardware, so RFC for now.
The documentation states the outdoor mode is only enabled in case
outdoor_chanlist is defined in the sites wifi5 configurationsection:
This currently does not hold true, as Outdoor mode is always activated
for these devices on first setup, even in case the site does not specify
an outdoor chanlist.
Furthermore, it also does not make sense to show the option neither in
setup-modes basic nor advences configuration view in case the site is
lacking an out door chanlist.
This patch will disable outdoor mode on new installs in case the outdoor
chanlist is missing. It will also not show the respective configuration
options in this case.
Signed-off-by: David Bauer mail@david-bauer.net