Revert System.Console.OutputEncoding to not break the shell

[inosik]

Description

When using any external tool from a FAKE script (MSBuild, test runners, Paket, …), after FAKE exits, the terminal is broken. I tried different console emulators (Windows console, PowerShell, ConsoleZ) and different shells (cmd.exe, PowerShell, bash), and all show the same behavior.

Repro steps

1. Open a cmd.exe window.

2. Run FAKE with a target which invokes an external tool.

As I found out, the assignment of the output encoding before starting the process is the problem. The assigned value remains set after FAKE exits, which apparently breaks the input handling of the shell.

Actual behavior

After FAKE exits, I can't use the German Umlaut-characters. When I try to type an "Ä" for example, it doesn't appear on the screen, but now I'm able to delete already printed output from the console.

I reproduced this with fsi:

Known workarounds

Use FAKE in its own terminal window.

Related information

• Operating system: Windows 7
• .NET Runtime, CoreCLR or Mono Version: .NET 4.6.2

[inosik]

Changing back to ibm850 encoding with chcp 850 after running FAKE seems to fix this. But maybe FAKE should restore the old encoding?

[matthid]

Thanks for this! I noticed this several times in the past as well. In fact this is probably why I use git bash mostly (which doesn't seem to have this problem). I never managed to reproduce this or find the reason :)

[inosik]

In fact this is probably why I use git bash mostly (which doesn't seem to have this problem).

I use the Git Bash most of the time, too, but that doesn't make any difference to me. The only terminal I tried, which doesn't seem to have this problem, is Hyper.