Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ProcessHelper.ensureProcessesHaveStopped (#389) #412

Merged
merged 2 commits into from
Apr 25, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/app/FakeLib/ProcessHelper.fs
Original file line number Diff line number Diff line change
Expand Up @@ -448,12 +448,12 @@ let killAllCreatedProcesses() =
/// ## Parameters
/// - `name` - The name of the processes in question.
/// - `timeout` - The timespan to time out after.
let ensureProcessesHaveStopped name timeout =
let ensureProcessesHaveStopped name timeout =
let endTime = DateTime.Now.Add timeout
while DateTime.Now <= endTime && (getProcessesByName name <> Seq.empty) do
while DateTime.Now <= endTime && not (getProcessesByName name |> Seq.isEmpty) do
tracefn "Waiting for %s to stop (Timeout: %A)" name endTime
Thread.Sleep 1000
if getProcessesByName name <> Seq.empty then
if not (getProcessesByName name |> Seq.isEmpty) then
failwithf "The process %s has not stopped (check the logs for errors)" name

/// Execute an external program and return the exit code.
Expand Down
1 change: 1 addition & 0 deletions src/deploy.web/Fake.Deploy.Web/Fake.Deploy.Web.fsproj
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@
<ItemGroup>
<Reference Include="FSharp.Core, Version=4.3.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
<Private>True</Private>
<HintPath>..\..\..\lib\fsi\FSharp.Core.dll</HintPath>
</Reference>
<Reference Include="log4net">
<HintPath>..\..\..\packages\log4net.2.0.3\lib\net40-full\log4net.dll</HintPath>
Expand Down