Update dependencies and add net452 support. #379
Conversation
gdziadkiewicz
force-pushed
the
feature/EnableNet452
branch
from
770c105 to
b3b42f0
Compare
gdziadkiewicz
changed the title
gdziadkiewicz
force-pushed
the
feature/EnableNet452
branch
3 times, most recently
from
846cfe9 to
65080f0
Compare
gdziadkiewicz
force-pushed
the
feature/EnableNet452
branch
from
65080f0 to
dd09c38
Compare
gdziadkiewicz
changed the title
|
@panesofglass Can you take a look? |
| "isRoot": true, | ||
| "tools": { | ||
| "fake-cli": { | ||
| "version": "5.19.0", |
There was a problem hiding this comment.
Decided to go with this approach due to error described in fsprojects/FAKE#2447 .
| ] | ||
| }, | ||
| "paket": { | ||
| "version": "5.226.0", |
There was a problem hiding this comment.
and used the opportunity to change paket approach to the prefered one https://fsprojects.github.io/Paket/get-started.html#NET-Core-preferred
| dotnet: 2.1.300 | ||
| sudo: false # use the new container-based Travis infrastructure | ||
| mono: none | ||
| dotnet: 3.1.100 |
There was a problem hiding this comment.
Required for local tools
| @@ -15,12 +17,12 @@ group Build | |||
|
|
|||
| group Test | |||
| source https://api.nuget.org/v3/index.json | |||
| framework: netcoreapp21 | |||
| framework: net46, netcoreapp21 | |||
There was a problem hiding this comment.
I decided to go with net46 as I didn't want to downgrade fsunit version.
| <Optimize>true</Optimize> | ||
| <Tailcalls>true</Tailcalls> | ||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
| <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(OS)' != 'Windows_NT' "> |
There was a problem hiding this comment.
Could be probably remove as described in https://atlemann.github.io/fsharp/2018/03/07/multi-targeting-mono.html
|
@forki @mausch @panesofglass Can you help with getting this merged and released? This will have additional benefit of solving #382 build problems. |
Why?
I want to use FSharpx.Extras in my legacy net452 project.
How?
I restored net45 support to FSharpx.Collections (support was dropped in 2.0.0) and now I'm able to build FSharpx.Extras for net452 (FSharpx.Async works on net452).