Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nft token sort #930

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Remove nft token sort #930

merged 2 commits into from
Feb 28, 2025

Conversation

JasonTulp
Copy link
Contributor

@JasonTulp JasonTulp commented Feb 28, 2025 •
edited
Loading

Description

  • Removes the sort fucntion from NFT.add_user_tokens to prevent unnecessary work

Context & Background

  • sort was slowing down the node when performing it on accounts that owned many tokens

Notes & Additional Information

  • NFT pallet will need a refactor for the owned tokens type, this is the first step towards optimising it completely

Release Notes

Key Changes

Type of Change

  • Runtime Changes
  • Client Changes

zees-dev
zees-dev approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@zees-dev zees-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JasonTulp JasonTulp merged commit ff1c87c into main Feb 28, 2025
2 checks passed
@JasonTulp JasonTulp deleted the fix/nft-optimisation branch February 28, 2025 01:10
@JasonTulp JasonTulp mentioned this pull request Feb 28, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surangap surangap surangap approved these changes

@zees-dev zees-dev zees-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonTulp @surangap @zees-dev