-
Notifications
You must be signed in to change notification settings - Fork 17
node-typescript-app skaffold and helm config #23
node-typescript-app skaffold and helm config #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks promising.
@@ -0,0 +1,3 @@ | |||
# my-service Helm Chart | |||
|
|||
This is a default chart created with `helm create` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since a lot of people (including myself) aren't familiar with Helm, would you mind including a very short description and link to https://helm.sh?
I opened a separate pull request(#24) for the yarn cache so we can fasttrack that. I have also been able to get helm and skaffold to work together. It's not great because the default hem configuration separates out the image name and tag, and skaffold relies on finding the full |
This PR looks good. I don't mind the workaround for now. |
I think this should be good to go for now |
This currently does not work, but I created a issue on the skaffold repository:
GoogleContainerTools/skaffold#961