Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose storage.ErrNotExists for non existing documents #3318

Merged
merged 6 commits into from
Oct 11, 2022
Merged

expose storage.ErrNotExists for non existing documents #3318

merged 6 commits into from
Oct 11, 2022

Conversation

rangzen
Copy link
Contributor

@rangzen rangzen commented Oct 9, 2022

Description:

Fixes #3083

Let me know all the changes you need because I am pretty sure this one will not be right in the first place.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass. (I don't pass all the tests because of the Android things.)

@coveralls
Copy link

coveralls commented Oct 9, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 61.391% when pulling fbcabcd on rangzen:feature/storage_errnotexists into 66536c9 on fyne-io:develop.

andydotxyz
andydotxyz requested changes Oct 9, 2022
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great approach. I wonder if there are any other places in Storage or Docs that should be using the new error?

Jacalz
Jacalz previously approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the PR

andydotxyz
andydotxyz requested changes Oct 9, 2022
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a const ordering request

@Jacalz Jacalz mentioned this pull request Oct 10, 2022
Closed
3 tasks
Jacalz
Jacalz requested changes Oct 10, 2022
View reviewed changes
Jacalz
Jacalz approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice work!

@Jacalz Jacalz merged commit e8f2499 into fyne-io:develop Oct 11, 2022
@Jacalz
Copy link
Member

Jacalz commented Oct 11, 2022

Congratulations on your first contribution to Fyne and thanks for your work :)

@rangzen
Copy link
Contributor Author

rangzen commented Oct 11, 2022

Thank you @Jacalz ! It is an interesting project. Happy to have discovered it! I will probably try some experiment on the mobile part.

@rangzen rangzen deleted the feature/storage_errnotexists branch October 11, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rangzen @coveralls @Jacalz @andydotxyz