Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable comments in package dag file #17408

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Enable comments in package dag file #17408

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2783fb6
Ignore lines starting with # in build packages script
jdavcs Jan 31, 2024
01402e2
Use if/then/fi for readability; minor linting
jdavcs Feb 1, 2024
2337c9c
Partially remove bash-specific syntax
jdavcs Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/build_packages.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,17 @@ set -ex
# Change to packages directory.
cd "$(dirname "$0")"

# ensure ordered by dependency dag
# Ensure ordered by dependency dag
while read -r package_dir; do
if [ -z "$package_dir" ]; then
# Skip empty lines
# Ignore empty lines
if [[ -z $package_dir ]]; then
continue
fi
# Ignore lines beginning with `#`
if [[ $package_dir =~ ^#.* ]]; then
continue
fi

printf "\n========= RELEASING PACKAGE %s =========\n\n" "$package_dir"

cd "$package_dir"
Expand Down
14 changes: 10 additions & 4 deletions packages/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,25 @@ TEST_PYTHON=${TEST_PYTHON:-"python3"}
TEST_ENV_DIR=${TEST_ENV_DIR:-$(mktemp -d -t gxpkgtestenvXXXXXX)}

"$TEST_PYTHON" -m venv "$TEST_ENV_DIR"
# shellcheck disable=SC1091
. "${TEST_ENV_DIR}/bin/activate"
pip install --upgrade pip setuptools wheel
if [ $FOR_PULSAR -eq 0 ]; then
pip install -r../lib/galaxy/dependencies/pinned-typecheck-requirements.txt
fi

# ensure ordered by dependency DAG
# Ensure ordered by dependency DAG
while read -r package_dir || [ -n "$package_dir" ]; do # https://stackoverflow.com/questions/12916352/shell-script-read-missing-last-line
if [ -z "$package_dir" ]; then
# Skip empty lines
# Ignore empty lines
if [[ -z $package_dir ]]; then
continue
fi
printf "\n========= TESTING PACKAGE ${package_dir} =========\n\n"
# Ignore lines beginning with `#`
if [[ $package_dir =~ ^#.* ]]; then
continue
fi

printf "\n========= TESTING PACKAGE %s =========\n\n" "$package_dir"

cd "$package_dir"

Expand Down
Loading