refactor(gatsby): Move query/page-query-runner to query/index #13375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
Moocar
force-pushed
the
page-query-runner-to-index
branch
from
f8f6dd7 to
96293ab
Compare
Moocar
force-pushed
the
page-query-runner-to-index
branch
from
cff1569 to
dfbc209
Compare
|
Published in gatsby@2.3.24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #13064, I mentioned that we should move
page-query-runner.jstoquery/index.jssince it is becoming a general interface for running queries, whether static, or page. This PR makes that happen.Note, I'm not sold on requiring
query/indexasqueryUtilas I have in this PR, but can't think of a better name. Very much open to suggestions.Related Issues