-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add probabilistic iterative methods #983
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth adding it to changelog.md?
Feel free to pushback
Should the example script use this new method?
Performance reviewCommit
|
Performance reviewCommit
|
PR Type
Description
Adds the
reduce_iterative()
method toKernelHerding
. Closes #977.How Has This Been Tested?
Existing tests pass as expected.
New tests introduced with this change verify that
reduce_iterative()
works correctly. Due to the probabilistic nature of the solver whenprobabilistic=True
, the exact behaviour is hard to verify, hence the test replacesjax.random.choice
with a deterministic choice function.Does this PR introduce a breaking change?
No.
Checklist before requesting a review