Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rstar in geo-types to 0.4.0 #361

Closed
frewsxcv opened this issue May 13, 2019 · 4 comments · Fixed by #373
Closed

Bump rstar in geo-types to 0.4.0 #361

frewsxcv opened this issue May 13, 2019 · 4 comments · Fixed by #373
Labels
geo-types breaking change

Comments

@frewsxcv
Copy link
Member

Gonna hold off on this until we're ready to do a geo-types bump.
@Stoeoef
Copy link
Contributor

Stoeoef commented Jun 4, 2019

I've recently published 0.4.0. Only new features were added, hopefully no bug this time...
You should not see any breaking changes in regards to rstar's API surface.

@frewsxcv frewsxcv changed the title Bump rstar in geo-types to 0.3.0 Bump rstar in geo-types to 0.4.0 Jun 9, 2019
@urschrei
Copy link
Member

urschrei commented Jul 2, 2019

Just trying to fix this, and getting a confusing error related to RTreeObject:

the trait `rstar::Point` is not implemented for geo_types::Line<T>
note: required because of the requirements on the impl of rstar::RTreeObject for geo_types::Line<T>
note: required by rstar::RTree

I'm not sure why this is arising, since our Point<T> has an rstar::Point impl…

@Stoeoef
Copy link
Contributor

Stoeoef commented Jul 14, 2019

Just bumping the version information works for me (comparison), all tests pass and the benchmarks run on nightly. What did you do differently?

@urschrei
Copy link
Member

@Stoeoef I think I bumped the geo_types version without bumping the geo version 🤦‍♂️. Works fine here too.

@frewsxcv frewsxcv mentioned this issue Jul 24, 2019
Merged
bors bot added a commit that referenced this issue Jul 24, 2019
@bors @frewsxcv
Merge #373
1984def 
373: Bump rstar to 0.4. r=frewsxcv a=frewsxcv

Fixes #361

Co-authored-by: Corey Farwell <coreyf@rwell.org>
bors bot added a commit that referenced this issue Jul 27, 2019
@bors @frewsxcv
Merge #373
8beca03 
373: Bump rstar to 0.4. r=frewsxcv a=frewsxcv

Fixes #361

Co-authored-by: Corey Farwell <coreyf@rwell.org>
@bors bors bot closed this as completed in #373 Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
geo-types breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump rstar to 0.4. georust/geo
3 participants
@urschrei @frewsxcv @Stoeoef