Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some deprecated methods #1012

Merged
merged 4 commits into from
May 4, 2023
Merged

Conversation

michaelkirk
Copy link
Member

@michaelkirk michaelkirk commented May 4, 2023

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Hint, you probably want to review this one with whitespace changes hidden.

Fixes #1010

@michaelkirk michaelkirk changed the title remove deprecated MapCoords variants remove some deprecated methods May 4, 2023
@lnicola
Copy link
Member

lnicola commented May 4, 2023

Well, that's one way to fix that compiler error 😂.

@michaelkirk
Copy link
Member Author

I'm not a sophisticated person.

@michaelkirk
Copy link
Member Author

bors r=urschrei,lnicola

Are you still there bors? 😢

@bors
Copy link
Contributor

bors bot commented May 4, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit c4ad568 into main May 4, 2023
@bors bors bot deleted the mkirk/remove-deprecated-map-coords branch May 4, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling with cross set to target armv7-unknown-linux-gnueabihf causes issues with try_map_coords_inplace.
3 participants