Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: SpadeTriangulation was not actually configurable #1123

Merged
merged 1 commit into from
Dec 7, 2023
Merged

FIX: SpadeTriangulation was not actually configurable #1123

merged 1 commit into from
Dec 7, 2023

Conversation

michaelkirk
Copy link
Member

@michaelkirk michaelkirk commented Dec 6, 2023 •
edited
Loading

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

@michaelkirk michaelkirk force-pushed the mkirk/configurable-spade branch from b93ffe7 to b81b5a9 Compare December 6, 2023 20:25
@michaelkirk michaelkirk requested a review from RobWalt December 6, 2023 20:25
RobWalt
RobWalt approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@RobWalt RobWalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, I totally oversaw that 🤦🏼 Thanks!

@michaelkirk michaelkirk added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit fd7e7b1 Dec 7, 2023
@michaelkirk michaelkirk deleted the mkirk/configurable-spade branch December 7, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urschrei urschrei urschrei approved these changes

@RobWalt RobWalt RobWalt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelkirk @urschrei @RobWalt