Split core geo types into new geo-types crate. #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to have a closer look, but very much in favour of the idea. This keeps tripping us up in other ecosystem crates. |
|
I like this idea. |
frewsxcv
force-pushed
the
geo-typese
branch
3 times, most recently
from
09ae95a to
637e223
Compare
frewsxcv
commented
Apr 23, 2018
| @@ -0,0 +1,94 @@ | |||
| // FIXME: everything in this file is copy/paste from the 'geo' crate. ideally we | |||
| // wouldn't have this duplication | |||
There was a problem hiding this comment.
the (non-public) traits below are unfortunately necessary to keep the spade trait impls on the geo types in geo-types/src/lib.rs. for now it's a little messy, but i think we can reevaluate this in the future. i.e. do we really need spade?
frewsxcv
changed the title
|
@urschrei @jdroenner Alright, finished working on this. If either of you have some time, would love a pair of eyes 👀 for a review! |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 3, 2018
201: Split core geo types into new geo-types crate. r=frewsxcv a=frewsxcv The idea is to move the core data types into a new, minimal crate called `geo-types`. The idea here is to have all third party crates (e.g. `rust-gdal`, `rust-geojson`) rely on this new crate instead pulling in all the baggage of the `geo` crate. This shouldn't be a breaking change since all types in `geo-types` are reexported by the `geo` crate. Co-authored-by: Corey Farwell <coreyf@rwell.org>
|
👏 |
Build succeeded |
This was referenced May 3, 2018
bors bot
added a commit
to georust/geojson
that referenced
this pull request
May 4, 2018
93: Switch 'geo' dependency to 'geo-types'. r=frewsxcv a=frewsxcv georust/geo#201 # before ``` geojson v0.10.0 (file:///Users/corey/dev/rust-geojson) [dependencies] ├── geo v0.8.2 │ [dependencies] │ ├── failure v0.1.1 │ │ [dependencies] │ │ ├── backtrace v0.3.6 │ │ │ [dependencies] │ │ │ ├── cfg-if v0.1.2 │ │ │ ├── libc v0.2.37 │ │ │ └── rustc-demangle v0.1.7 │ │ └── failure_derive v0.1.1 │ │ [dependencies] │ │ ├── quote v0.3.15 │ │ ├── syn v0.11.11 │ │ │ [dependencies] │ │ │ ├── quote v0.3.15 (*) │ │ │ ├── synom v0.11.3 │ │ │ │ [dependencies] │ │ │ │ └── unicode-xid v0.0.4 │ │ │ └── unicode-xid v0.0.4 (*) │ │ └── synstructure v0.6.1 │ │ [dependencies] │ │ ├── quote v0.3.15 (*) │ │ └── syn v0.11.11 (*) │ ├── num-traits v0.2.1 │ ├── serde v1.0.27 │ ├── serde_derive v1.0.27 │ │ [dependencies] │ │ ├── quote v0.3.15 (*) │ │ ├── serde_derive_internals v0.19.0 │ │ │ [dependencies] │ │ │ ├── syn v0.11.11 (*) │ │ │ └── synom v0.11.3 (*) │ │ └── syn v0.11.11 (*) │ └── spade v1.4.0 │ [dependencies] │ ├── cgmath v0.16.0 │ │ [dependencies] │ │ ├── approx v0.1.1 │ │ ├── num-traits v0.1.43 │ │ │ [dependencies] │ │ │ └── num-traits v0.2.1 (*) │ │ └── rand v0.4.2 │ │ [dependencies] │ │ └── libc v0.2.37 (*) │ ├── clamp v0.1.0 │ ├── nalgebra v0.14.0 │ │ [dependencies] │ │ ├── alga v0.5.2 │ │ │ [dependencies] │ │ │ ├── approx v0.1.1 (*) │ │ │ ├── num-complex v0.1.42 │ │ │ │ [dependencies] │ │ │ │ ├── num-traits v0.2.1 (*) │ │ │ │ └── rustc-serialize v0.3.24 │ │ │ └── num-traits v0.1.43 (*) │ │ ├── approx v0.1.1 (*) │ │ ├── generic-array v0.8.3 │ │ │ [dependencies] │ │ │ ├── nodrop v0.1.12 │ │ │ └── typenum v1.9.0 │ │ ├── matrixmultiply v0.1.14 │ │ │ [dependencies] │ │ │ └── rawpointer v0.1.0 │ │ ├── num-complex v0.1.42 (*) │ │ ├── num-traits v0.1.43 (*) │ │ ├── rand v0.4.2 (*) │ │ └── typenum v1.9.0 (*) │ ├── num v0.1.42 │ │ [dependencies] │ │ ├── num-bigint v0.1.43 │ │ │ [dependencies] │ │ │ ├── num-integer v0.1.36 │ │ │ │ [dependencies] │ │ │ │ └── num-traits v0.2.1 (*) │ │ │ ├── num-traits v0.2.1 (*) │ │ │ ├── rand v0.4.2 (*) │ │ │ └── rustc-serialize v0.3.24 (*) │ │ │ [dev-dependencies] │ │ │ └── rand v0.4.2 (*) │ │ ├── num-complex v0.1.42 (*) │ │ ├── num-integer v0.1.36 (*) │ │ ├── num-iter v0.1.35 │ │ │ [dependencies] │ │ │ ├── num-integer v0.1.36 (*) │ │ │ └── num-traits v0.2.1 (*) │ │ ├── num-rational v0.1.42 │ │ │ [dependencies] │ │ │ ├── num-bigint v0.1.43 (*) │ │ │ ├── num-integer v0.1.36 (*) │ │ │ ├── num-traits v0.2.1 (*) │ │ │ └── rustc-serialize v0.3.24 (*) │ │ └── num-traits v0.2.1 (*) │ ├── pdqselect v0.1.0 │ └── smallvec v0.3.3 │ [dev-dependencies] │ └── cgmath v0.16.0 (*) ├── num-traits v0.2.1 (*) ├── serde v1.0.27 (*) └── serde_json v1.0.10 [dependencies] ├── dtoa v0.4.2 ├── itoa v0.3.4 ├── num-traits v0.2.1 (*) └── serde v1.0.27 (*) ``` # after ``` geojson v0.11.0 (file:///Users/corey/dev/rust-geojson) [dependencies] ├── geo-types v0.1.0 │ [dependencies] │ └── num-traits v0.2.1 ├── num-traits v0.2.1 (*) ├── serde v1.0.27 └── serde_json v1.0.10 [dependencies] ├── dtoa v0.4.2 ├── itoa v0.3.4 ├── num-traits v0.2.1 (*) └── serde v1.0.27 (*) ``` Co-authored-by: Corey Farwell <coreyf@rwell.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to move the core data types into a new, minimal crate called
geo-types. The idea here is to have all third party crates (e.g.rust-gdal,rust-geojson) rely on this new crate instead pulling in all the baggage of thegeocrate.This shouldn't be a breaking change since all types in
geo-typesare reexported by thegeocrate.