Change closure for exterior_mut() and interiors_mut() to be FnOnce. #479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current form of
exteriors_mut
accepts a closure of FnMut. This causes this case not to compile:While this does:
FnMut is to allow a closure to have a mutable state, so that it can be called multiple times, modifying that state. The closure is only called once, and the part that is mutable is the parameter to it, so it doesn't need to be an FnMut. FnOnce is a superset of FnMut, so changing the trait bound to be FnOnce should have no affect on existing use cases, while enabling new ones.