Fix numerical stability in computing area #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add check for closed in `twice_signed_ring_area` + shift coordinates to smaller numbers before computing area + add test for stability of area with shifts + add test to verify open `LineString` returns `None` as `winding_order`
|
As per discussions with @urschrei , we now check and return 0 in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We modify
fn twice_signed_ring_areainwinding_order.rsto first shift the coordinates by the min over the geometry, before computing the area. The logic is correct as long as the inputLineStringis closed. To the best of my understanding, this is the case.Also added a test to verify stability. Closes #481