Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement centroid for multilinestring #485

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

mcassels
Copy link
Contributor

@mcassels mcassels commented Aug 5, 2020

No description provided.

Copy link
Member

@urschrei urschrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me – just a minor change to the comment and we can merge it. Thank you!

{
type Output = Option<Point<T>>;

// The Centroid of a MultiLineString is the mean of the middles of all the constituent linestrings,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you reword this slightly into "…the mean of the centroids…", and turn it into a doc comment (///)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@urschrei urschrei merged commit 7def594 into georust:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants