Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ChamberlainDuquetteArea for all geo types. #833

Merged
merged 2 commits into from
May 16, 2022
Merged

Implement ChamberlainDuquetteArea for all geo types. #833

merged 2 commits into from
May 16, 2022

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented May 15, 2022 •
edited
Loading

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

michaelkirk
michaelkirk approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I feel like there are a handful of algorithms that it'd be useful to add support to impl Geometry for — thanks for tackling one.

bors r=lnicola,michaelkirk

@bors
Copy link
Contributor

bors bot commented May 16, 2022

Build succeeded:

@bors bors bot merged commit 8a41ca7 into main May 16, 2022
@bors bors bot deleted the frewsxcv-campber branch May 16, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkirk michaelkirk michaelkirk approved these changes

@lnicola lnicola lnicola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frewsxcv @michaelkirk @lnicola