Reexport everything from proj.
#839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like if we're going to expose `proj`, we might as well expose everything. My use case is I need access to `proj::ProjCreateError`, which wasn't exposed prior to this.
michaelkirk
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
I think that this makes sense.
The alternative is that users have to deduce which version of proj is being installed by geo, and copy that into their Cargo.toml (and then keep it in sync whenever geo changes). Instead we just "include" all of proj within geo (iff you've enabled the with-proj feature).
|
bors r=michaelkirk |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like if we're going to expose
proj, we might as well exposeeverything. My use case is I need access to
proj::ProjCreateError,which wasn't exposed prior to this.
CHANGES.mdif knowledge of this change could be valuable to users.