Implement ConvexHull for all geometry types #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewsxcv
reviewed
Aug 12, 2022
geo/src/algorithm/convex_hull/mod.rs
Outdated
| @@ -147,4 +106,32 @@ fn swap_remove_to_first<'a, T>(slice: &mut &'a mut [T], idx: usize) -> &'a mut T | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
| mod test; | |||
There was a problem hiding this comment.
Should your new tests be added to the existing test.rs file? https://github.com/georust/geo/blob/main/geo/src/algorithm/convex_hull/test.rs This might be unused after your changes
There was a problem hiding this comment.
Oh, good catch! I'm not sure what I was thinking. I've addressed this in a fixup commit (975a28d) which I'll squash and then merge.
michaelkirk
force-pushed
the
mkirk/convex-hull
branch
from
975a28d to
b2945e8
Compare
|
bors r=frewsxcv |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Fixes #887