Remove rotating calipers algorithm #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
approved these changes
Oct 12, 2022
|
Should we add a regression test after this is removed so we don't accidentally reintroduce the bug? |
urschrei
force-pushed
the
fast_path_retirement
branch
from
2e61749 to
52ee481
Compare
urschrei
force-pushed
the
fast_path_retirement
branch
from
09a9b66 to
8522a1c
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.The
Polygon-Polygondistance rotating calipers algorithm for convex polygons has been a source of bugs for a while, and I've exhausted my ability to fix the latest one (#917), so, as its author, I'm proposing the algorithm's removal.This PR currently makes one other small change: it removes thePolygon-Polygonintersection check as it's relatively expensive and our iterative NN algorithm performs the check anyway as part of the point-line distance check.