Adds GeodesicDestination and GeodesicBearing
#991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - but I'll leave it open a bit in case anyone else wants to comment.
Not in this pull request, but I wonder if in the future we should rename the |
michaelkirk
reviewed
Mar 6, 2023
2 tasks
michaelkirk
reviewed
Mar 6, 2023
| assert_eq!(p_2, Point::new(9.27411867078536, 48.8403266058781)); | ||
|
|
||
| let expected = Point::new(9.27411867078536, 48.8403266058781); | ||
| assert_relative_eq!(p_2.x(), expected.x(), epsilon = 1.0e-6); |
There was a problem hiding this comment.
Since we've implemented some approx traits for Point, you should be able to just assert_relative_eq(p2, expected, epsilon = 1.e-6).
There was a problem hiding this comment.
Oh I didn't know that! Good catch. Fixed
|
bors r+ I'm going to merge this, and plan to include it in geo-0.24.0, which I'll plan to publish tomorrow unless I hear otherwise. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.This adds the following:
GeodesicDestinationtrait to complement theHaversineDestinationtraitGeodesicBearingtrait to complement theBearingtraitGeodesicIntermediatetrait