-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added vec2type struct and unitstype enum; changed IconStyle hot_spot #13
Conversation
from tuple to Vec2.
Thanks for opening the PR! I added a requirement in CI for linting and formatting, could you rebase off of main and resolve the issues there? |
Absolutely! Thanks! |
I'm assuming the merge commit above was something you were trying to avoid when you mentioned rebasing? If so I'll try to fix that. |
Thanks for making those updates! It looks like there are still some failing format issues. And don't worry about the merge commit, I'll do a squash merge that will remove it when this is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for those updates! Sorry I missed these on an initial pass
…dAltitudeMode error with InvalidUnits
Thanks so much for these updates! I'll squash merge this now and add you to the changelog |
from tuple to Vec2.