Run tests without default features in CI #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
approved these changes
Jun 15, 2022
Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds running
cargo testwith--no-default-featuresto the CI test step, and splits out runningcargo benchinto its own job since it's not important there. This should prevent running into any issues like #21.I had to update some of the doctests with
#[cfg]but I'm commenting that out so that it doesn't show in the final documentation output.Also includes two unrelated changes to reduce the amount of duplication in running CI (currently running on branch and PR for every PR made from a branch on this repo) and to make two links clickable that I ran into while testing
cargo doclocally. These seemed pretty small and easiest to just incorporate hereFeedback is welcome! This should be a pretty minor fix as long as CI passes