Add kml:Location #7
Conversation
src/types/location.rs
Outdated
| /// `kml:Location`, [10.10](http://docs.opengeospatial.org/is/12-007r2/12-007r2.html#542) in the KML | ||
|
|
There was a problem hiding this comment.
Minor thing, but to make sure the doc string works we can remove the extra space
| /// `kml:Location`, [10.10](http://docs.opengeospatial.org/is/12-007r2/12-007r2.html#542) in the KML | |
| /// `kml:Location`, [10.10](http://docs.opengeospatial.org/is/12-007r2/12-007r2.html#542) in the KML |
src/types/location.rs
Outdated
| pub latitude: T, | ||
| pub longitude: T, | ||
| pub altitude: T, | ||
| pub altitude_mode: AltitudeMode, |
There was a problem hiding this comment.
It looks like Location doesn't support altitude mode based on the description in the spec unless I'm missing something
There was a problem hiding this comment.
Yes, you're right, when I read the description of "altitude" Altitude of origin measured in meters and interpreted according to kml:altitudeMode. I thought maybe it can be set but now taking another look at it, the description was refereeing to the altitudeMode set on the Parent structure which is Model.
src/types/geometry.rs
Outdated
| @@ -14,6 +15,7 @@ use crate::types::polygon::Polygon; | |||
| #[derive(Debug, Clone, PartialEq)] | |||
| pub enum Geometry<T: CoordType = f64> { | |||
| Point(Point<T>), | |||
| Location(Location<T>), | |||
There was a problem hiding this comment.
I am admittedly not very familiar with this project - but is Location really a Geometry?
There was a problem hiding this comment.
At least it seems out of sync with the above comment, which says this enum represents http://docs.opengeospatial.org/is/12-007r2/12-007r2.html#432.
There was a problem hiding this comment.
Good point! It's in a weird in-between here, since it's in the geometries section http://docs.opengeospatial.org/is/12-007r2/12-007r2.html#431 but not part of the AbstractGeometryGroup. It probably would make more sense to leave this and the other elements in this section that aren't in AbstractGeometryGroup out of this enum
|
Thanks, @pjsier would be happy to work on the other similar issues if they're up for grabs. |
|
Sure! The other issues here are open, and I think once those are done that |
Changes:
Add Location struct
Add Location reader and writer.
closes #4