Update proj-sys to use libproj 9.4.0 #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re: macos failure
But the latest version available on hombrew is 9.4.0 https://formulae.brew.sh/formula/proj Do we need to |
|
Worked like a charm. Feel free to review! |
Closed
michaelkirk
approved these changes
Apr 1, 2024
| @@ -141,6 +141,7 @@ jobs: | |||
| runs-on: macos-latest | |||
| env: | |||
| _PROJ_SYS_TEST_EXPECT_BUILD_FROM_SRC: 0 | |||
| HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: TRUE | |||
There was a problem hiding this comment.
Wow, this variable name is a doozy. (I realize it's from the homebrew project - not something you came up with 🤷♂️).
Is the idea that since we're manually updating we can ignore the auto-update feature?
There was a problem hiding this comment.
Yes, as it transiently causes the build to fail as those dependent package installs are randomly failing for no reason (see last two CI failures on macos)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.