fix: Fix issue with incorrect base URL generation due to empty string in region variable #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunomiguelpinto
changed the title
brunomiguelpinto
added
the
documentation
ivannovosad
approved these changes
Oct 24, 2024
vincent-pochet
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where an empty string in the region variable resulted in an incorrect base URL being generated, specifically https://api. {region}getlago.com/api/v1 instead of https://api.getlago.com/api/v1.
The previous configuration for the region variable used an empty string as the default, which caused the incorrect URL structure. The fix involves adjusting the default value of the region variable and ensuring that the resulting URL is properly constructed as https://api.getlago.com/api/v1 when no region is specified.