feat(docker-compose): Add heathcheck for redis and pg #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienbourdeau
force-pushed
the
feat/heathcheck
branch
from
0ab1f5f to
b0653d2
Compare
jdenquin
approved these changes
Jan 21, 2025
|
btw this was already done here https://github.com/getlago/lago/pull/428/files |
|
Yeah, it was extracted from there because the PR was conflicting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add docker heathcheck for PG and Redis.
I didn't come up with this, it's extracted from this (outdated) PR: #428
If we want to do the migrate step, I'll do it in a separate PR. I thought those two heathcheck were valuable.