Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation script fixing #25

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Validation script fixing #25

merged 3 commits into from
Mar 22, 2023

Conversation

ignapzs
Copy link
Contributor

@ignapzs ignapzs commented Mar 21, 2023

Performing this slight changes, I think issue #24 gets fixed.
It also includes a slight clarification regarding working with venv.

ignapzs added 3 commits March 20, 2023 22:07
@ignapzs
docs:
0cad58e 
- setting explicit venv deactivation instructions
- fixing proper path to schema from base script path
@ignapzs
fix:
18662b8 
- fixing proper path to schema
@ignapzs
feat:
08bb5f8 
- specific validation exception
ydarias
ydarias approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@ydarias ydarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @ignapzs. Thank you very much for your contribution!

claps

@ydarias
Copy link
Contributor

ydarias commented Mar 22, 2023

This PR fixed #24

@ydarias ydarias merged commit 8db822f into getmanfred:master Mar 22, 2023
@ydarias ydarias mentioned this pull request Mar 22, 2023
Closed
@ignapzs ignapzs mentioned this pull request Mar 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydarias ydarias ydarias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignapzs @ydarias