Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements #27

Merged
merged 6 commits into from
Mar 27, 2023
Merged

Minor improvements #27

merged 6 commits into from
Mar 27, 2023

Conversation

ignapzs
Copy link
Contributor

@ignapzs ignapzs commented Mar 21, 2023

While taking a look to #24 and #26, I thought this could be some nice minor improvements.
What do you think?

ignapzs added 3 commits March 20, 2023 21:49
@ignapzs
docs:
05d0c93 
- setting proper style on centered elements
- fixing anchors in README file
- removing closing tag that not matches opening tag
@ignapzs
chore:
f2bb9eb 
- including new folders for IDE and python venv
@ignapzs
docs:
ae44898 
- fixing anchor in CONTRIBUTING file
- typo in CONTRIBUTING file
ydarias
ydarias suggested changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@ydarias ydarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ignapzs great work again :-)

I left a few comments though since some changes are not working in the intended way.

We really appreciate your work!

ignapzs and others added 3 commits March 23, 2023 15:35
@ignapzs @ydarias
doc: fix wrong anchor link
a072f34 
Co-authored-by: Yeray Darias  <ydarias@gmail.com>
@ignapzs
Revert "docs:"
f70c443 
This reverts commit 05d0c93.
@ignapzs
doc:
abf211d 
- removing closing tag that not matches opening tag
- setting "alt" attribute on images
- setting SNGULAR logo picture
@ignapzs
Copy link
Contributor Author

ignapzs commented Mar 23, 2023

Hi @ydarias!
I've just made some new changes and corrections regarding given comments. It also includes a fix for another pending issue.
What do you think about them?

@ydarias
Copy link
Contributor

ydarias commented Mar 27, 2023

I think it is great! :-)

@ydarias ydarias merged commit 0f88ec3 into getmanfred:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydarias ydarias ydarias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignapzs @ydarias