Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v1p): Give V1P users 1 extra potato per transact1on #210

Closed
wants to merge 1 commit into from

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Aug 27, 2024

Treat the V1Ps like they should.

This feature aligns with our goal hierarchy!

@Dav1dde Dav1dde requested a review from a team as a code owner August 27, 2024 14:06
Copy link

codecov bot commented Aug 27, 2024

Bundle Report

Bundle size has no change ✅

Bundle name Size Change
gib-potato-esm 513.55kB 0 bytes

@Dav1dde
Copy link
Member Author

Dav1dde commented Aug 27, 2024

Tagging @s1gr1d in this, because she is another V1P.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.96%. Comparing base (a5eabe0) to head (7402ec4).

Files Patch % Lines
src/Service/AwardService.php 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #210      +/-   ##
============================================
+ Coverage     26.92%   26.96%   +0.03%     
- Complexity      311      312       +1     
============================================
  Files            74       74              
  Lines          3086     3089       +3     
============================================
+ Hits            831      833       +2     
- Misses         2255     2256       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dav1dde Dav1dde self-assigned this Aug 27, 2024
@cleptric
Copy link
Member

Yes, no, we're not doing this 🙂

@cleptric cleptric closed this Aug 28, 2024
@Dav1dde
Copy link
Member Author

Dav1dde commented Aug 28, 2024

D:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants