fix: fixes several cases where we access an undefined value #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
billyvg
changed the title
lastFullSnapshotEvent can be undefined
Fixes JAVASCRIPT-2S3R
billyvg
force-pushed
the
fix-lastfulltimestampevent-undefined
branch
from
f45938d to
5666910
Compare
billyvg
added a commit
that referenced
this pull request
Apr 26, 2024
Fixes several cases where we access an undefined value. In the case of `lastFullSnapshotEvent`, it can be undefined if we receive an incremental event before a full snapshot. This can happen, for example, if a user refreshes while canvas worker is working and on reload it finishes to call the mutation callback and before fullsnapshot occurs. Fixes JAVASCRIPT-2S3R Fixes JAVASCRIPT-2QS1 Fixes JAVASCRIPT-2FQ5 Fixes JAVASCRIPT-2H2H
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several cases where we access an undefined value.
In the case of
lastFullSnapshotEvent, it can be undefined if we receive an incremental event before a full snapshot. This can happen, for example, if a user refreshes while canvas worker is working and on reload it finishes to call the mutation callback and before fullsnapshot occurs.Fixes JAVASCRIPT-2S3R
Fixes JAVASCRIPT-2QS1
Fixes JAVASCRIPT-2FQ5
Fixes JAVASCRIPT-2H2H