-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ensure to use unwrapped versions of setTimeout
/ clearTimeout
#176
Conversation
Let's see if that helps with Angular performance some more...!
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very interesting! It kinda makes sense after thinking about it. ZoneJS patches all of these global APIs so let's see 🍿
(long term this might phase out with Angular becoming zone-less in favor of signals but this will take a long time until it's used broadly)
Yeah, I'd say the bundle size hit is acceptable here, and we can revert it later if we want/need to! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
We will also want to do this for the setTimeouts in our replay package
Let's ship this, I'd say, and see if it already improves things, than we can also add this to replay itself, at least in hot paths related to rrweb events etc! |
@mydea when I was debugging, I saw that it was being triggered by our click handler in the replay package |
sad! I guess let's implement it there as well then, will add some bundle size but I guess it's worth it! |
…t` (#176) Let's see if that helps with Angular performance some more...! Closes getsentry/sentry-javascript#11661 (hopefully...)
Let's see if that helps with Angular performance some more...!
Closes getsentry/sentry-javascript#11661 (hopefully...)