Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ef integration test #1515

Merged
merged 20 commits into from
Mar 16, 2022
Merged

add ef integration test #1515

merged 20 commits into from
Mar 16, 2022

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Mar 9, 2022

#skip-changelog

@getsentry getsentry deleted a comment from codecov-commenter Mar 9, 2022
@getsentry getsentry deleted a comment from codecov-commenter Mar 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #1515 (8f842ca) into main (475a5c9) will decrease coverage by 1.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1515      +/-   ##
==========================================
- Coverage   84.33%   82.85%   -1.49%     
==========================================
  Files         219      219              
  Lines        7388     7388              
  Branches     1416     1416              
==========================================
- Hits         6231     6121     -110     
- Misses        725      843     +118     
+ Partials      432      424       -8     
Impacted Files Coverage Δ
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 0.00% <0.00%> (-100.00%) ⬇️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 0.00% <0.00%> (-70.43%) ⬇️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 4.54% <0.00%> (-68.19%) ⬇️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 25.00% <0.00%> (-37.50%) ⬇️
...ntry/Integrations/NetFxInstallationsIntegration.cs 28.57% <0.00%> (-28.58%) ⬇️
...als/DiagnosticSource/SentryDiagnosticSubscriber.cs 60.00% <0.00%> (-28.00%) ⬇️
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 53.44% <0.00%> (-5.18%) ⬇️
src/Sentry/Internal/SdkComposer.cs 70.21% <0.00%> (-4.26%) ⬇️
src/Sentry/Internal/BackgroundWorker.cs 92.02% <0.00%> (-1.45%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 475a5c9...8f842ca. Read the comment docs.

@SimonCropp
Copy link
Contributor Author

@bruno-garcia @mattjohnsonpint this is ready for a review

@mattjohnsonpint
Copy link
Contributor

Re-ran the checks to pass the intermittent error on macOS (#1516), but now it fails intermittently on Windows in SqlListenerTests.RecordsEf. Looks like the order the spans are in is not consistent.

image

@SimonCropp
Copy link
Contributor Author

@mattjohnsonpint that should be fixed now

@SimonCropp SimonCropp merged commit b26a2fb into main Mar 16, 2022
@SimonCropp SimonCropp deleted the add-ef-integration-test branch March 16, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants