Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nestjs): Instrument event handlers #14307

Merged
merged 8 commits into from
Nov 15, 2024

Conversation

chargome
Copy link
Member

This pr adds auto-instrumentation for @nestjs-event-emitter.
Before this, errors thrown in event handlers were not catched by the global error filter and had no performance tracing attached.

This is what the trace now looks like (example with one throwing event handler):
Screenshot 2024-11-14 at 16 01 20

closes #13167

Copy link
Contributor

github-actions bot commented Nov 14, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.77 KB - -
@sentry/browser - with treeshaking flags 21.53 KB - -
@sentry/browser (incl. Tracing) 35.27 KB - -
@sentry/browser (incl. Tracing, Replay) 71.99 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.37 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.3 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.15 KB - -
@sentry/browser (incl. Feedback) 39.93 KB - -
@sentry/browser (incl. sendFeedback) 27.42 KB - -
@sentry/browser (incl. FeedbackAsync) 32.23 KB - -
@sentry/react 25.52 KB - -
@sentry/react (incl. Tracing) 38.23 KB - -
@sentry/vue 26.92 KB - -
@sentry/vue (incl. Tracing) 37.1 KB - -
@sentry/svelte 22.91 KB - -
CDN Bundle 24.13 KB - -
CDN Bundle (incl. Tracing) 37.05 KB - -
CDN Bundle (incl. Tracing, Replay) 71.71 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.06 KB - -
CDN Bundle - uncompressed 70.73 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.93 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.45 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.67 KB - -
@sentry/nextjs (client) 38.35 KB - -
@sentry/sveltekit (client) 35.85 KB - -
@sentry/node 134.35 KB +0.23% +303 B 🔺
@sentry/node - without tracing 96.24 KB - -
@sentry/aws-serverless 106.49 KB - -

View base workflow run

@chargome chargome self-assigned this Nov 14, 2024
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👌

@chargome chargome merged commit c21bf07 into develop Nov 15, 2024
149 checks passed
@chargome chargome deleted the cg/nestjs-instrument-event-listeners branch November 15, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instrument NestJS event listeners
2 participants