Disable maxMessageLength truncation by default #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Should help those Angular messages. |
|
Do you have a preference on longer message length or default to no truncation? I'm not even sure that 1000 would cover all the Angular stuff? |
|
Mmm. Yeah, let's remove it ... and if it truly becomes a problem, reinstate it. (I'm guessing it wont.) |
mattrobenolt
changed the title
mattrobenolt
force-pushed
the
maxlength
branch
from
62d902b to
65b3763
Compare
|
@benvinegar Alright, it's just disabled by default now instead. I'd rather leave it in for now in case someone wants to explicitly limit it if they were using their own transport or whatever and had a limitation. |
|
Works for me. |
mattrobenolt
added a commit
that referenced
this pull request
Dec 30, 2015
Disable maxMessageLength truncation by default
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now send lots more data since we send via POST, so remove this restriction.
Alternatively, we can either remove this entirely, or handle a
0value to disable truncation entirely. I can't see any other client that does this type of truncation. iirc, I added this originally to limit the packet size being sent, which isn't really needed anymore.