Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vue.js (2.0) plugin #688

Merged
merged 5 commits into from
Aug 16, 2016
Merged

Add Vue.js (2.0) plugin #688

merged 5 commits into from
Aug 16, 2016

Conversation

benvinegar
Copy link
Contributor

@benvinegar benvinegar commented Aug 16, 2016

cc @dcramer @mattrobenolt @macqueen


This change is Reviewable

@dcramer
Copy link
Member

dcramer commented Aug 16, 2016

Gonna confirm with @mitsuhiko, but I think we can change contexts to allow rich types for arbitrary data. If we do that we can move this out of extra and have it be its own context.

@benvinegar
Copy link
Contributor Author

Sure, but part of me would prefer to put it in extra rather than have another interface block in the UI that takes up only 2-3 rows.


.. sourcecode:: html

<script src="http://builds.emberjs.com/tags/v2.3.1/ember.prod.js"></script>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@macqueen
Copy link

Reviewed 2 of 3 files at r1.
Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.


docs/integrations/vue.rst, line 29 [r2] (raw file):

Previously, benvinegar (Ben Vinegar) wrote…

Oops

haha

Comments from Reviewable

@benvinegar benvinegar merged commit 892008a into master Aug 16, 2016
@benvinegar benvinegar deleted the vue-plugin branch August 16, 2016 19:56
denstepa pushed a commit to denstepa/raven-js that referenced this pull request Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants