Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix UI issues when we get a bare span envelope #726

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

BYK
Copy link
Member

@BYK BYK commented Mar 5, 2025

Fixes #721

Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 4:32pm

@BYK BYK enabled auto-merge (squash) March 5, 2025 14:46
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 71.11111% with 13 lines in your changes missing coverage. Please review.

Project coverage is 31.95%. Comparing base (0635b3c) to head (cab7b75).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ations/sentry/components/insights/QuerySummary.tsx 0.00% 4 Missing ⚠️
...ay/src/integrations/sentry/data/sentryDataCache.ts 86.20% 4 Missing ⚠️
...ntegrations/sentry/components/events/EventList.tsx 50.00% 1 Missing ⚠️
...y/components/explore/traces/TraceDetails/index.tsx 50.00% 1 Missing ⚠️
...ry/components/explore/traces/spans/SpanDetails.tsx 66.66% 1 Missing ⚠️
...s/overlay/src/integrations/sentry/data/profiles.ts 50.00% 1 Missing ⚠️
packages/overlay/src/integrations/sentry/index.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
+ Coverage   31.76%   31.95%   +0.18%     
==========================================
  Files          92       92              
  Lines        5811     5833      +22     
  Branches      114      118       +4     
==========================================
+ Hits         1846     1864      +18     
- Misses       3965     3969       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BYK BYK merged commit f731d91 into main Mar 5, 2025
17 checks passed
@BYK BYK deleted the qsyqpqpsplux branch March 5, 2025 16:39
BYK pushed a commit that referenced this pull request Mar 13, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @spotlightjs/astro@3.1.0

### Minor Changes

-   Make event id a link to raw envelope on envelope details page
    ([#729](#729))

### Patch Changes

- Fix envelope sorting and local classification
([#727](#727))

- Fix UI issues when we get a bare span envelope
([#726](#726))

- Fix span details modal resetting trace view tree state on close (for
reals this time)
    ([#728](#728))

- Fixes detection of Sentry SDK frames in Vite projects
([#718](#718))

-   Updated dependencies

\[[`9ca9ed1b97119757d8b1ec6de24d781aefe8b76c`](9ca9ed1),

[`c39cfb3622fe19ccc5df822d30d16298f254cb17`](c39cfb3),

[`f731d9171ead5aea21152f1d3bfa89e473a7272c`](f731d91),

[`97dfa768846c76da47521f551b1bb45c683a23d9`](97dfa76),

[`79506149f545487e67cdff7eab7393c619c8afd9`](7950614)]:
    -   @spotlightjs/spotlight@2.12.0

## @spotlightjs/electron@1.6.0

### Minor Changes

-   Make event id a link to raw envelope on envelope details page
    ([#729](#729))

### Patch Changes

- Fix envelope sorting and local classification
([#727](#727))

- Fix UI issues when we get a bare span envelope
([#726](#726))

- Fix span details modal resetting trace view tree state on close (for
reals this time)
    ([#728](#728))

- Fixes detection of Sentry SDK frames in Vite projects
([#718](#718))

-   Updated dependencies

\[[`9ca9ed1b97119757d8b1ec6de24d781aefe8b76c`](9ca9ed1),

[`c39cfb3622fe19ccc5df822d30d16298f254cb17`](c39cfb3),

[`f731d9171ead5aea21152f1d3bfa89e473a7272c`](f731d91),

[`97dfa768846c76da47521f551b1bb45c683a23d9`](97dfa76),

[`448062fd45799832fc3240656d543696d438d5ab`](448062f),

[`79506149f545487e67cdff7eab7393c619c8afd9`](7950614)]:
    -   @spotlightjs/overlay@2.13.0

## @spotlightjs/overlay@2.13.0

### Minor Changes

-   Make event id a link to raw envelope on envelope details page
    ([#729](#729))

- Added Search support in Trace details
([#730](#730))

### Patch Changes

- Fix envelope sorting and local classification
([#727](#727))

- Fix UI issues when we get a bare span envelope
([#726](#726))

- Fix span details modal resetting trace view tree state on close (for
reals this time)
    ([#728](#728))

- Fixes detection of Sentry SDK frames in Vite projects
([#718](#718))

## @spotlightjs/spotlight@2.12.0

### Minor Changes

-   Make event id a link to raw envelope on envelope details page
    ([#729](#729))

### Patch Changes

- Fix envelope sorting and local classification
([#727](#727))

- Fix UI issues when we get a bare span envelope
([#726](#726))

- Fix span details modal resetting trace view tree state on close (for
reals this time)
    ([#728](#728))

- Fixes detection of Sentry SDK frames in Vite projects
([#718](#718))

-   Updated dependencies

\[[`9ca9ed1b97119757d8b1ec6de24d781aefe8b76c`](9ca9ed1),

[`c39cfb3622fe19ccc5df822d30d16298f254cb17`](c39cfb3),

[`f731d9171ead5aea21152f1d3bfa89e473a7272c`](f731d91),

[`97dfa768846c76da47521f551b1bb45c683a23d9`](97dfa76),

[`448062fd45799832fc3240656d543696d438d5ab`](448062f),

[`79506149f545487e67cdff7eab7393c619c8afd9`](7950614)]:
    -   @spotlightjs/overlay@2.13.0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to ingest and display span events
1 participant