ready to release v1.5.0 #2109
ready to release v1.5.0 #2109
Conversation
thinkerou
commented
Oct 27, 2019
•
thinkerou
commented
- Add break-backward remind log
Codecov Report
@@ Coverage Diff @@
## master #2109 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 40 40
Lines 2236 2236
=======================================
Hits 2208 2208
Misses 14 14
Partials 14 14Continue to review full report at Codecov.
|
|
When next version will be realeased? |
|
Very Urgently Expecting tag1.5 |
|
Anything? |
|
@thinkerou maybe move PR or issue to 1.6 milestone? See https://github.com/gin-gonic/gin/milestone/10 |
|
@appleboy done, but still have one pull request, please review, thanks! |
|
@appleboy all pull request have updated, and freeze the master until release v1.5.0 |
There was a problem hiding this comment.
In help to release v1.5.0, I've checked the master commits since v1.4.0 (currently only the recent half of them).
There are some breaking changes in it. Did you consider releasing it as v2.0.0 then to follow Go modules convention?
I took the lens of a reader, i.e. developer, not knowing about Gin's internals while reviewing the changelogs. That's why I suggest to remove many lines and renaming the changes to be understandable from user's side.
CHANGELOG.md
Outdated
| - [FIX] Refactor(context.go): GetPostFormMap [#2051](https://github.com/gin-gonic/gin/pull/2051) | ||
| - [FIX] Adjust Render.Redirect test case [#2053](https://github.com/gin-gonic/gin/pull/2053) | ||
| - [FIX] Make countParams more readable [#2052](https://github.com/gin-gonic/gin/pull/2052) | ||
| - [FIX] Use url.URL.Query instead of parsing query [#2063](https://github.com/gin-gonic/gin/pull/2063) |
There was a problem hiding this comment.
All 4 are no bug fixes, just refactorings. I would leave them out as its just boilerplate to read.
|
Is it available? |
Co-Authored-By: Dominik-K <dominik-k@mailbox.org>
Co-Authored-By: Dominik-K <dominik-k@mailbox.org>
Co-Authored-By: Dominik-K <dominik-k@mailbox.org>
Co-Authored-By: Dominik-K <dominik-k@mailbox.org>
Co-Authored-By: Dominik-K <dominik-k@mailbox.org>
Co-Authored-By: Dominik-K <dominik-k@mailbox.org>
Co-Authored-By: Dominik-K <dominik-k@mailbox.org>
Co-Authored-By: Dominik-K <dominik-k@mailbox.org>
Co-Authored-By: Dominik-K <dominik-k@mailbox.org>
Co-Authored-By: Dominik-K <dominik-k@mailbox.org>
Co-Authored-By: Dominik-K <dominik-k@mailbox.org>
Co-Authored-By: Dominik-K <dominik-k@mailbox.org>
Co-Authored-By: Dominik-K <dominik-k@mailbox.org>
|
@Dominik-K thanks! updated! |
|
@appleboy please review, thanks! |
|
When will it be released |
When the guys will have time to review. |
|
Hi, all, v1.5.0 released! |
* ready to release v1.5.0 * add some commit log * Update CHANGELOG.md Co-Authored-By: Dominik-K <dominik-k@mailbox.org> * Update CHANGELOG.md Co-Authored-By: Dominik-K <dominik-k@mailbox.org> * Update CHANGELOG.md Co-Authored-By: Dominik-K <dominik-k@mailbox.org> * Update CHANGELOG.md Co-Authored-By: Dominik-K <dominik-k@mailbox.org> * Update CHANGELOG.md Co-Authored-By: Dominik-K <dominik-k@mailbox.org> * Update CHANGELOG.md Co-Authored-By: Dominik-K <dominik-k@mailbox.org> * Update CHANGELOG.md Co-Authored-By: Dominik-K <dominik-k@mailbox.org> * Update CHANGELOG.md Co-Authored-By: Dominik-K <dominik-k@mailbox.org> * Update CHANGELOG.md Co-Authored-By: Dominik-K <dominik-k@mailbox.org> * Update CHANGELOG.md Co-Authored-By: Dominik-K <dominik-k@mailbox.org> * Update CHANGELOG.md Co-Authored-By: Dominik-K <dominik-k@mailbox.org> * Update CHANGELOG.md Co-Authored-By: Dominik-K <dominik-k@mailbox.org> * Update CHANGELOG.md Co-Authored-By: Dominik-K <dominik-k@mailbox.org> * remove refactor and update readme pr
