Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rust analysis #2773

Merged
merged 6 commits into from
Feb 20, 2025
Merged

Support rust analysis #2773

merged 6 commits into from
Feb 20, 2025

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Feb 19, 2025 •
edited
Loading

This is supposed to enable rust analysis for the staff ship only.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

Paolo Tranquilli and others added 3 commits February 19, 2025 15:56
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 20, 2025
View reviewed changes
@redsun82 redsun82 marked this pull request as ready for review February 20, 2025 11:08
@redsun82 redsun82 requested a review from a team as a code owner February 20, 2025 11:08
dbartol
dbartol previously approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@dbartol dbartol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redsun82 redsun82 dismissed dbartol’s stale review February 20, 2025 16:49

the approval was given by mistake on one commit only :)

dbartol
dbartol approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@dbartol dbartol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whole thing LGTM.

@redsun82 redsun82 merged commit 9856c48 into main Feb 20, 2025
270 checks passed
@redsun82 redsun82 deleted the redsun82/rust branch February 20, 2025 17:03
@github-actions github-actions bot mentioned this pull request Feb 21, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbartol dbartol dbartol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redsun82 @dbartol