Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 fix #140

Merged
merged 3 commits into from
Oct 1, 2021
Merged

IPv6 fix #140

merged 3 commits into from
Oct 1, 2021

Conversation

yoannchaudet
Copy link
Contributor

This PR fixes logic related to our recent rollout of IPv6 for Pages.

AAAA record presence is now also looking at the actual record name not to be confused by a CNAME resolution.

For instance in:

dig AAAA pages.github.com

; <<>> DiG 9.10.6 <<>> AAAA pages.github.com
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 35585
;; flags: qr rd ra; QUERY: 1, ANSWER: 5, AUTHORITY: 0, ADDITIONAL: 0

;; QUESTION SECTION:
;pages.github.com.		IN	AAAA

;; ANSWER SECTION:
pages.github.com.	3600	IN	CNAME	github.github.io.
github.github.io.	1451	IN	AAAA	2606:50c0:8000::153
github.github.io.	1451	IN	AAAA	2606:50c0:8001::153
github.github.io.	1451	IN	AAAA	2606:50c0:8002::153
github.github.io.	1451	IN	AAAA	2606:50c0:8003::153

We used to consider AAAA record were present on the zone while they are not. They are resolved via the CNAME record.

cc/ https://github.com/github/pages-engineering/issues/787

@yoannchaudet yoannchaudet requested a review from a team October 1, 2021 18:16
@yoannchaudet yoannchaudet merged commit 209be81 into master Oct 1, 2021
@JamesMGreene JamesMGreene deleted the ipv6-fix branch January 13, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants