fix external editor for cmd and bat on windows

Cargo.toml

@@ -60,7 +60,9 @@ which = "4.4"
 pprof = { version = "0.11", features = ["flamegraph"], optional = true }
 
 [dev-dependencies]
+asyncgit = { path = "asyncgit", features = ["test_utils"] }
 pretty_assertions = "1.3"
+serial_test = "2.0.0"
 tempfile = "3.4"
 
 [badges]

asyncgit/Cargo.toml

@@ -14,6 +14,7 @@ keywords = ["git"]
 [dependencies]
 crossbeam-channel = "0.5"
 easy-cast = "0.5"
+env_logger = "0.10"
 git2 = "0.17"
 log = "0.4"
 # git2 = { path = "../../extern/git2-rs", features = ["vendored-openssl"]}
@@ -24,6 +25,7 @@ rayon-core = "1.11"
 scopetime = { path = "../scopetime", version = "0.1" }
 serde = { version = "1.0", features = ["derive"] }
 shellexpand = "3.1"
+tempfile = "3.4"
 thiserror = "1.0"
 unicode-truncate = "0.2.0"
 url = "2.3"
@@ -32,10 +34,10 @@ url = "2.3"
 env_logger = "0.10"
 invalidstring = { path = "../invalidstring", version = "0.1" }
 pretty_assertions = "1.3"
-serial_test = "1.0"
-tempfile = "3.4"
+serial_test = "2.0"
 
 [features]
 default = ["trace-libgit"]
 trace-libgit = []
 vendor-openssl = ["openssl-sys"]
+test_utils = []

asyncgit/src/lib.rs

@@ -23,7 +23,7 @@
 // #![deny(clippy::expect_used)]
 //TODO: consider cleaning some up and allow specific places
 #![allow(clippy::significant_drop_tightening)]
-
+#![allow(clippy::multiple_crate_versions)]
 pub mod asyncjob;
 mod blame;
 mod branches;

asyncgit/src/sync/mod.rs

@@ -100,8 +100,19 @@ pub use utils::{
 
 pub use git2::ResetType;
 
-#[cfg(test)]
-mod tests {
+#[cfg(feature = "test_utils")]
+/// test utilities - exported now
+// see https://github.com/rust-lang/cargo/issues/8379
+pub mod tests {
+	// these are now not under 'test' so they get clippied with 'all-features'
+	// we dont care about tests that panic
+	#![allow(clippy::unwrap_used, clippy::missing_panics_doc)]
+	// minor niggles
+	#![allow(clippy::nursery)]
+	// this clippy is confused by the name 'read'
+	// should probably be changed to read_into
+	#![allow(clippy::read_zero_byte_vec)]
+
 	use super::{
 		commit,
 		repository::repo,
@@ -278,7 +289,7 @@ mod tests {
 
 	// init log
 	fn init_log() {
-		let _ = env_logger::builder()
+		let _b = env_logger::builder()
 			.is_test(true)
 			.filter_level(log::LevelFilter::Trace)
 			.try_init();

deny.toml

@@ -22,5 +22,6 @@ version = "1.0.3"
 multiple-versions = "deny"
 skip-tree = [
     { name = "windows-sys" },
-    { name = "hermit-abi" }
+    { name = "hermit-abi" },
+    { name = "syn" }
 ]