Included <exception> std header #117
Closed
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required to call 'std::terminate_handler' on line 296 (now 297)
|
Looks like we have this include in later versions of the code, are you building 3.3 for LPC support or is there some other reason? |
|
The introduction of CANlib in v3.4 presented greater compatibility issues when building on debian than v3.3. Reverting was the path of least resistance. Didn't dig too deep into v3.4 - if you've already included exception in subsequent releases, I suppose this conversation is moot. Thanks! |
|
I need to update the build instructions to cover the combined F4 and H7
builds.
…On Tue, 19 Jul 2022, 18:07 Stephen Opet III, ***@***.***> wrote:
The introduction of CANlib in v3.4 presented greater compatibility issues
when building on debian than v3.3. Reverting was the path of least
resistance.
Didn't dig too deep into v3.4 - if you've already included in subsequent
releases, I suppose this conversation is moot. Thanks!
—
Reply to this email directly, view it on GitHub
<#117 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATUSBRBM3V2FDZYZS7XWZ3VU3OELANCNFSM535SZQMA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header is required to compile v3.3 on Debian Linux, or an error gets thrown on the call to 'std::terminate_handler', line 296 (now 297).
Admittedly not necessary if the package is built on Gloomy's recommended stack. But the rest of the build runs rather smoothly on debian, and the header is quite small to include