Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP feat: add support of testing.T based tests with gnodev test #192

Closed
wants to merge 3 commits into from

Conversation

moul
Copy link
Member

@moul moul commented May 13, 2022

  • adds support of testing.T-style tests on gnodev test

moul added 2 commits May 13, 2022 21:40
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul self-assigned this May 13, 2022
@moul moul added core labels May 13, 2022
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
Copy link
Member Author

moul commented May 14, 2022

I have an issue, to run the test suites from gnodev instead of go test, I need to call some internal code from Golang, i.e.,

  1. It will require build constraints to support both go1.17 and go1.18 (go1.18 adds support for fuzzing in the struct); so it will be complex to write and maintain.
  2. in terms of the license, the go internal codebase is using a BSD-style license, and I need to know if it may be an issue for Gno.

Some options:

  • do nothing (no testing.T-style tests in gnodev)
  • do it, as said above
  • find a hack, like generating a temporary _test.go file in the same folder, that allows to then call go test

I'm confused tonight and need more time to think on it. But please, anyone, any advice is greatly welcomed:)

@moul moul requested a review from jaekwon May 17, 2022 11:11
@moul
Copy link
Member Author

moul commented May 20, 2022

Waiting for #208 that looks better

@moul
Copy link
Member Author

moul commented May 30, 2022

Closing in favor of #208

@moul moul closed this May 30, 2022
@moul moul deleted the dev/moul/testing branch July 5, 2022 09:15
@moul moul added this to the 🏗2️⃣ test2.gno.land milestone Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant